Hi Jason, I don't know if you had a chance to look into this, but I just uploaded my first patch to gerrit and I also seem to be missing the ability to add reviewers. When I type someone into the reviewers box there is no auto complete and when I add someone manually and click OK, the reviewer field is still blank.
Regards, Paul -----Original Message----- From: gem5-dev [mailto:[email protected]] On Behalf Of Jason Lowe-Power Sent: Saturday, March 25, 2017 11:38 AM To: gem5 Developer List <[email protected]> Subject: Re: [gem5-dev] adding reviewers in gerrit? Hi Gabe, Hmm... It works for me. It's possible that we don't have the permissions set up correctly to allow anyone to add reviewers. I just tested with a non-admin account and it doesn't work for that account either. I'll look into it. Cheers, Jason On Sat, Mar 25, 2017 at 5:32 AM Gabe Black <[email protected]> wrote: > Hi folks. I've uploaded a few CLs to gerrit now, and I notice that I > can't add reviewers since it claims everyone I try to add isn't a > registered user. That's very odd, because I'm trying to add people who > have given me review feedback on earlier changes, and people who I can > look up activity for on gerrit. Does anybody know why it's not > behaving for me? My other CL got reviewed so it's not a problem yet, > but it would be nice if I could direct my CLs to the appropriate people > instead of hoping they see them. > > Gabe > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
