Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/2904
to review the following change.
Change subject: ruby, arm: Forward invalidations to the local exclusive
monitor
......................................................................
ruby, arm: Forward invalidations to the local exclusive monitor
ARM systems require local exclusive monitors for the implementation of
synchronization primitives between processors. A ruby memory system
needs to forward invalidations to the local exclusive monitors to
to correctly determine their state.
Change-Id: I7bc4d0f2a5be0f4e36a25c87aa4a81a3f086fb3c
Reviewed-by: Andreas Sandberg <[email protected]>
---
M configs/ruby/Ruby.py
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configs/ruby/Ruby.py b/configs/ruby/Ruby.py
index 7a1a8c3..79205bd 100644
--- a/configs/ruby/Ruby.py
+++ b/configs/ruby/Ruby.py
@@ -232,6 +232,8 @@
# currently, 2 scenarios warrant forwarding evictions to the CPU:
# 1. The O3 model must keep the LSQ coherent with the caches
# 2. The x86 mwait instruction is built on top of coherence
invalidations
- if options.cpu_type == "detailed" or buildEnv['TARGET_ISA'] == 'x86':
+ # 3. The local exclusive monitor in ARM systems
+ if options.cpu_type == "detailed" or \
+ buildEnv['TARGET_ISA'] in ('x86', 'arm'):
return True
return False
--
To view, visit https://gem5-review.googlesource.com/2904
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc4d0f2a5be0f4e36a25c87aa4a81a3f086fb3c
Gerrit-Change-Number: 2904
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
