Andreas Sandberg has submitted this change and it was merged. (
https://gem5-review.googlesource.com/3240 )
Change subject: arm: Remove unused DumpStatsPCEventF class in FreeBSD system
......................................................................
arm: Remove unused DumpStatsPCEventF class in FreeBSD system
The DumpStatsPCEventF is declared but lacks an implementation. This
confuses RTTI in clang. Remove this class since it is clearly not
needed.
Change-Id: Ib95f09f2ba8593f8d0e072b96afd5f8a9ed31070
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-by: Curtis Dunham <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/3240
Reviewed-by: B.A. Zeeb <[email protected]>
---
M src/arch/arm/freebsd/system.cc
M src/arch/arm/freebsd/system.hh
2 files changed, 1 insertion(+), 20 deletions(-)
Approvals:
B.A. Zeeb: Looks good to me, approved
Andreas Sandberg: Looks good to me, approved
diff --git a/src/arch/arm/freebsd/system.cc b/src/arch/arm/freebsd/system.cc
index da427e8..84538e1 100644
--- a/src/arch/arm/freebsd/system.cc
+++ b/src/arch/arm/freebsd/system.cc
@@ -51,7 +51,7 @@
using namespace FreeBSD;
FreebsdArmSystem::FreebsdArmSystem(Params *p)
- : GenericArmSystem(p), dumpStatsPCEventF(nullptr),
+ : GenericArmSystem(p),
enableContextSwitchStatsDump(p->enable_context_switch_stats_dump),
taskFile(nullptr), kernelPanicEvent(nullptr),
kernelOopsEvent(nullptr)
{
@@ -150,9 +150,6 @@
delete uDelaySkipEvent;
if (constUDelaySkipEvent)
delete constUDelaySkipEvent;
-
- if (dumpStatsPCEventF)
- delete dumpStatsPCEventF;
}
FreebsdArmSystem *
diff --git a/src/arch/arm/freebsd/system.hh b/src/arch/arm/freebsd/system.hh
index 17ace7c..50c405d 100644
--- a/src/arch/arm/freebsd/system.hh
+++ b/src/arch/arm/freebsd/system.hh
@@ -44,13 +44,8 @@
#include "params/FreebsdArmSystem.hh"
#include "sim/core.hh"
-class DumpStatsPCEventF;
-
class FreebsdArmSystem : public GenericArmSystem
{
- protected:
- DumpStatsPCEventF *dumpStatsPCEventF;
-
public:
/** Boilerplate params code */
typedef FreebsdArmSystemParams Params;
@@ -118,16 +113,5 @@
Addr bootReleaseAddr;
};
-class DumpStatsPCEventF : public PCEvent
-{
- public:
- DumpStatsPCEventF(PCEventQueue *q, const std::string &desc, Addr addr)
- : PCEvent(q, desc, addr)
- {}
-
- virtual void process(ThreadContext* tc);
-};
-
-
#endif // __ARCH_ARM_FREEBSD_SYSTEM_HH__
--
To view, visit https://gem5-review.googlesource.com/3240
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib95f09f2ba8593f8d0e072b96afd5f8a9ed31070
Gerrit-Change-Number: 3240
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: B.A. Zeeb <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
