Hello Gabe Black, Jason Lowe-Power, Nathan Binkert, Curtis Dunham,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/3222
to look at the new patch set (#2).
Change subject: python: Fix PyEvent reference counting bug
......................................................................
python: Fix PyEvent reference counting bug
The current implementation of reference counting for PyEvents only
partially works. The native object is currently kept alive while it is
in the event queue. However, if the Python object goes out of scope,
the Python side of this object is garbage collected which leaves a
"dangling" native object. This results in confusing error messages
where PyBind is unable to find the Python implementation of an event
when it is triggered.
Implement reference counting using the generalized reference counting
API instead.
Change-Id: I4e8e04abc4f61dff238d718065f5371e73b38ab3
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-by: Curtis Dunham <[email protected]>
---
M src/python/m5/event.py
M src/python/pybind11/event.cc
2 files changed, 46 insertions(+), 46 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/3222
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e8e04abc4f61dff238d718065f5371e73b38ab3
Gerrit-Change-Number: 3222
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nathan Binkert <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
