Sean Wilson has submitted this change and it was merged. (
https://gem5-review.googlesource.com/3720 )
Change subject: x86: Add consistent overrides to process.hh
......................................................................
x86: Add consistent overrides to process.hh
Change-Id: I912601b6f781a0bbedd06583c059589374f6d5c6
Signed-off-by: Sean Wilson <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/3720
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Joe Gross <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Reviewed-by: Brandon Potter <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/arch/x86/process.hh
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Brandon Potter: Looks good to me, approved
Gabe Black: Looks good to me, but someone else must approve
Joe Gross: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/process.hh b/src/arch/x86/process.hh
index fe31348..9cd5378 100644
--- a/src/arch/x86/process.hh
+++ b/src/arch/x86/process.hh
@@ -79,9 +79,10 @@
Addr gdtSize()
{ return _gdtSize; }
- SyscallDesc* getDesc(int callnum);
+ SyscallDesc* getDesc(int callnum) override;
- void setSyscallReturn(ThreadContext *tc, SyscallReturn
return_value);
+ void setSyscallReturn(ThreadContext *tc,
+ SyscallReturn return_value) override;
void clone(ThreadContext *old_tc, ThreadContext *new_tc,
Process *process, TheISA::IntReg flags);
@@ -131,12 +132,13 @@
public:
void argsInit(int pageSize);
- void initState();
+ void initState() override;
- X86ISA::IntReg getSyscallArg(ThreadContext *tc, int &i);
+ X86ISA::IntReg getSyscallArg(ThreadContext *tc, int &i) override;
/// Explicitly import the otherwise hidden getSyscallArg
using Process::getSyscallArg;
- void setSyscallArg(ThreadContext *tc, int i, X86ISA::IntReg val);
+ void setSyscallArg(ThreadContext *tc, int i,
+ X86ISA::IntReg val) override;
void clone(ThreadContext *old_tc, ThreadContext *new_tc,
Process *process, TheISA::IntReg flags);
};
@@ -173,13 +175,16 @@
public:
void argsInit(int pageSize);
- void initState();
+ void initState() override;
void syscall(int64_t callnum, ThreadContext *tc,
Fault *fault) override;
- X86ISA::IntReg getSyscallArg(ThreadContext *tc, int &i);
- X86ISA::IntReg getSyscallArg(ThreadContext *tc, int &i, int width);
- void setSyscallArg(ThreadContext *tc, int i, X86ISA::IntReg val);
+ X86ISA::IntReg getSyscallArg(ThreadContext *tc,
+ int &i) override;
+ X86ISA::IntReg getSyscallArg(ThreadContext *tc, int &i,
+ int width) override;
+ void setSyscallArg(ThreadContext *tc, int i,
+ X86ISA::IntReg val) override;
void clone(ThreadContext *old_tc, ThreadContext *new_tc,
Process *process, TheISA::IntReg flags);
};
--
To view, visit https://gem5-review.googlesource.com/3720
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I912601b6f781a0bbedd06583c059589374f6d5c6
Gerrit-Change-Number: 3720
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Wilson <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Joe Gross <[email protected]>
Gerrit-Reviewer: Sean Wilson <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
