Sean Wilson has submitted this change and it was merged. (
https://gem5-review.googlesource.com/3901 )
Change subject: arm: Fix memleak in Pl390 by adding destructor
......................................................................
arm: Fix memleak in Pl390 by adding destructor
Change-Id: I3395e64311f6aa7bbfb6eee9bfec82e832bcbd4d
Signed-off-by: Sean Wilson <spwils...@wisc.edu>
Reviewed-on: https://gem5-review.googlesource.com/3901
Reviewed-by: Jason Lowe-Power <ja...@lowepower.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/dev/arm/gic_pl390.cc
M src/dev/arm/gic_pl390.hh
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
diff --git a/src/dev/arm/gic_pl390.cc b/src/dev/arm/gic_pl390.cc
index ce27e94..7b63306 100644
--- a/src/dev/arm/gic_pl390.cc
+++ b/src/dev/arm/gic_pl390.cc
@@ -95,6 +95,12 @@
gem5ExtensionsEnabled = false;
}
+Pl390::~Pl390()
+{
+ for (int x = 0; x < CPU_MAX; x++)
+ delete postIntEvent[x];
+}
+
Tick
Pl390::read(PacketPtr pkt)
{
diff --git a/src/dev/arm/gic_pl390.hh b/src/dev/arm/gic_pl390.hh
index 05c9b5f..5c8a712 100644
--- a/src/dev/arm/gic_pl390.hh
+++ b/src/dev/arm/gic_pl390.hh
@@ -365,6 +365,7 @@
return dynamic_cast<const Params *>(_params);
}
Pl390(const Params *p);
+ ~Pl390();
DrainState drain() override;
--
To view, visit https://gem5-review.googlesource.com/3901
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3395e64311f6aa7bbfb6eee9bfec82e832bcbd4d
Gerrit-Change-Number: 3901
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Wilson <spwils...@wisc.edu>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Sean Wilson <spwils...@wisc.edu>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
