Andreas Sandberg has submitted this change and it was merged. (
https://gem5-review.googlesource.com/3966 )
Change subject: dev: Fix OnIdle test in DmaReadFifo
......................................................................
dev: Fix OnIdle test in DmaReadFifo
OnIdle() is never called since DMA active check is completely
opposite to what it should be. old active status should be 'true'
and new active status should be false for OnIdle to be called
Change-Id: I94eca50edbe96113190837c7f6e50a0d061158a6
Reported-by: Rohit Kurup <[email protected]>
Signed-off-by: Rohit Kurup <[email protected]>
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/3966
Reviewed-by: Michael LeBeane <[email protected]>
---
M src/dev/dma_device.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Michael LeBeane: Looks good to me, approved
diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc
index a78819a..f6f751c 100644
--- a/src/dev/dma_device.cc
+++ b/src/dev/dma_device.cc
@@ -438,7 +438,7 @@
handlePending();
resumeFill();
- if (!old_active && isActive())
+ if (old_active && !isActive())
onIdle();
}
--
To view, visit https://gem5-review.googlesource.com/3966
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I94eca50edbe96113190837c7f6e50a0d061158a6
Gerrit-Change-Number: 3966
Gerrit-PatchSet: 4
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Michael LeBeane <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
