Hello Nikos Nikoleris,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/4281

to review the following change.


Change subject: arch-alpha: Add missing overrides
......................................................................

arch-alpha: Add missing overrides

Change-Id: I3a52fcdb449c7df1612466270aa2c9b0a0f3afef
Reviewed-by: Nikos Nikoleris <[email protected]>
---
M src/arch/alpha/remote_gdb.hh
1 file changed, 3 insertions(+), 3 deletions(-)



diff --git a/src/arch/alpha/remote_gdb.hh b/src/arch/alpha/remote_gdb.hh
index 38ff919..c8ed709 100644
--- a/src/arch/alpha/remote_gdb.hh
+++ b/src/arch/alpha/remote_gdb.hh
@@ -50,8 +50,8 @@
 {
   protected:
     // Machine memory
-    bool acc(Addr addr, size_t len);
-    bool write(Addr addr, size_t size, const char *data);
+    bool acc(Addr addr, size_t len) override;
+    bool write(Addr addr, size_t size, const char *data) override;

     void insertHardBreak(Addr addr, size_t len) override;

@@ -75,7 +75,7 @@

   public:
     RemoteGDB(System *system, ThreadContext *context);
-    BaseGdbRegCache *gdbRegs();
+    BaseGdbRegCache *gdbRegs() override;
 };

 } // namespace AlphaISA

--
To view, visit https://gem5-review.googlesource.com/4281
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a52fcdb449c7df1612466270aa2c9b0a0f3afef
Gerrit-Change-Number: 4281
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to