Hello Andreas Sandberg,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/4480

to review the following change.


Change subject: arch-arm: Signal an event when executing store exclusives
......................................................................

arch-arm: Signal an event when executing store exclusives

When a store exclusive is executed, whether it is successful or not,
the exclusives monitor is cleared and therefore we need to signal an
event for the PE.

Change-Id: I383c88c769c0ac5f5d36c4b5d39c9681134d3a20
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/arch/arm/isa/insts/str.isa
M src/arch/arm/isa/insts/str64.isa
2 files changed, 10 insertions(+), 6 deletions(-)



diff --git a/src/arch/arm/isa/insts/str.isa b/src/arch/arm/isa/insts/str.isa
index 3f59569..a1b365c 100644
--- a/src/arch/arm/isa/insts/str.isa
+++ b/src/arch/arm/isa/insts/str.isa
@@ -1,6 +1,6 @@
 // -*- mode:c++ -*-

-// Copyright (c) 2010-2011 ARM Limited
+// Copyright (c) 2010-2011,2017 ARM Limited
 // All rights reserved
 //
 // The license below extends only to copyright in the software and shall
@@ -228,7 +228,8 @@

         def __init__(self, *args, **kargs):
             super(StoreImmEx, self).__init__(*args, **kargs)
-            self.codeBlobs["postacc_code"] = "Result = !writeResult;"
+            self.codeBlobs["postacc_code"] = \
+                  "Result = !writeResult; SevMailbox = 1;"

     class StoreImm(StoreImmInst, StoreSingle):
         decConstBase = 'LoadStoreImm'
@@ -307,7 +308,8 @@

         def __init__(self, *args, **kargs):
             super(StoreDoubleImmEx, self).__init__(*args, **kargs)
-            self.codeBlobs["postacc_code"] = "Result = !writeResult;"
+            self.codeBlobs["postacc_code"] = \
+                  "Result = !writeResult; SevMailbox = 1;"

     class StoreDoubleImm(StoreImmInst, StoreDouble):
         decConstBase = 'LoadStoreDImm'
diff --git a/src/arch/arm/isa/insts/str64.isa b/src/arch/arm/isa/insts/str64.isa
index c15dca1..f281c60 100644
--- a/src/arch/arm/isa/insts/str64.isa
+++ b/src/arch/arm/isa/insts/str64.isa
@@ -1,6 +1,6 @@
 // -*- mode:c++ -*-

-// Copyright (c) 2011-2013 ARM Limited
+// Copyright (c) 2011-2013,2017 ARM Limited
 // All rights reserved
 //
 // The license below extends only to copyright in the software and shall
@@ -277,7 +277,8 @@
         execBase = 'StoreEx64'
         def __init__(self, *args, **kargs):
             super(StoreEx64, self).__init__(*args, **kargs)
-            self.codeBlobs["postacc_code"] = "XResult = !writeResult;"
+            self.codeBlobs["postacc_code"] = \
+                 "XResult = !writeResult; SevMailbox = 1;"

     def buildStores64(mnem, NameBase, size, flavor="normal"):
         StoreImm64(mnem, NameBase + "_IMM", size, flavor=flavor).emit()
@@ -343,7 +344,8 @@
         writeback = False
         def __init__(self, *args, **kargs):
             super(StoreImmDEx64, self).__init__(*args, **kargs)
-            self.codeBlobs["postacc_code"] = "XResult = !writeResult;"
+            self.codeBlobs["postacc_code"] = \
+                 "XResult = !writeResult; SevMailbox = 1;"

     class StoreRegU64(StoreReg64):
         decConstBase = 'LoadStoreRegU64'

--
To view, visit https://gem5-review.googlesource.com/4480
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I383c88c769c0ac5f5d36c4b5d39c9681134d3a20
Gerrit-Change-Number: 4480
Gerrit-PatchSet: 1
Gerrit-Owner: Curtis Dunham <curtis.dun...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to