Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/4581 )
Change subject: x86: Use the new CondInst format for moves to/from control
registers.
......................................................................
x86: Use the new CondInst format for moves to/from control registers.
The condition is whether the control register index is valid.
Change-Id: I8a225fcfd4955032b5bbf7d3392ee5bcc7d6bc64
Reviewed-on: https://gem5-review.googlesource.com/4581
Reviewed-by: Michael LeBeane <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/x86/isa/decoder/two_byte_opcodes.isa
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Michael LeBeane: Looks good to me, approved
Gabe Black: Looks good to me, approved
diff --git a/src/arch/x86/isa/decoder/two_byte_opcodes.isa
b/src/arch/x86/isa/decoder/two_byte_opcodes.isa
index 97c3dd6..8b87568 100644
--- a/src/arch/x86/isa/decoder/two_byte_opcodes.isa
+++ b/src/arch/x86/isa/decoder/two_byte_opcodes.isa
@@ -360,9 +360,11 @@
0x04: decode LEGACY_DECODEVAL {
// no prefix
0x0: decode OPCODE_OP_BOTTOM3 {
- 0x0: MOV(Rd,Cd);
+ 0x0: CondInst::MOV(
+ {{isValidMiscReg(MISCREG_CR(MODRM_RM))}},Rd,Cd);
0x1: MOV(Rd,Dd);
- 0x2: MOV(Cd,Rd);
+ 0x2: CondInst::MOV(
+ {{isValidMiscReg(MISCREG_CR(MODRM_REG))}},Cd,Rd);
0x3: MOV(Dd,Rd);
default: UD2();
}
--
To view, visit https://gem5-review.googlesource.com/4581
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a225fcfd4955032b5bbf7d3392ee5bcc7d6bc64
Gerrit-Change-Number: 4581
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Michael LeBeane <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev