Hi Gabe, Seems OK to me. The code is in the public domain (no explicit copyright) except where that isn't allowed, in which case it's under MIT. So I think it's fine to incorporate into gem5. You're planning on using the amalgamated source ( https://github.com/open-source-parsers/jsoncpp/wiki/Amalgamated)? That seems the most reasonable.
Cheers, Jason On Mon, Sep 18, 2017 at 4:26 PM Gabe Black <[email protected]> wrote: > Hi folks. I know I've proposed a lot of things I haven't sent any patches > for yet, but here's one more. I recently debugged a problem where some > names had changed from the system a checkpoint was taken from and the one > it was loaded into. This left some objects uninitialized, and the > simulation didn't work. What I'd like to do is print some sort of warning > if there are unconsumed sections in the checkpoint (I think generally > checkpoints go from less to more or equal levels of complexity). It looks > like there's some very vestigial support for this sort of thing in the ini > parser code, but the only thing that used it was removed from the code base > sometime back in I think 2006. > > While digging around, it occurred to me how fairly crusty the old INI > support is, and how it would be nice to simplify/streamline the checkpoint > and config system and move it over to something which is truly hierarchical > like json. I found that we're already outputting a config.json, so that > will bring us a lot of the way there all on its own. > > One complication with this approach is that C++ doesn't have a built in > mechanism to parse json files. In some other work we've been doing, this > library seems to be doing the job pretty well. > > https://github.com/open-source-parsers/jsoncpp > > Would anybody object strongly if I went made this a dependency and > retrofitted things which produce/consume INI files to use json files > instead? > > Gabe > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
