Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/4760
Change subject: kvm: arm: Get rid of functions which just wrap the
subclasses version.
......................................................................
kvm: arm: Get rid of functions which just wrap the subclasses version.
The MuxingKvmGic class defined a few functions related to checkpointing
which
did nothing other than call the underlying Pl390 implementation. These are
unnecessary in general, and are particularly unnecessary for the loadState
function which is a very lightly used part of the checkpointing interface.
It's not actually defined in Pl390 either, and falls through to the
underlying implementation.
Change-Id: I84aae13d4966df0f4fdd1a72aee0bf1af01392ff
---
M src/arch/arm/kvm/gic.cc
M src/arch/arm/kvm/gic.hh
2 files changed, 0 insertions(+), 24 deletions(-)
diff --git a/src/arch/arm/kvm/gic.cc b/src/arch/arm/kvm/gic.cc
index d490265..887fa8d 100644
--- a/src/arch/arm/kvm/gic.cc
+++ b/src/arch/arm/kvm/gic.cc
@@ -184,12 +184,6 @@
}
void
-MuxingKvmGic::loadState(CheckpointIn &cp)
-{
- Pl390::loadState(cp);
-}
-
-void
MuxingKvmGic::startup()
{
Pl390::startup();
@@ -221,19 +215,6 @@
}
}
-void
-MuxingKvmGic::serialize(CheckpointOut &cp) const
-{
- // drain() already ensured Pl390 updated with KvmGic state if necessary
- Pl390::serialize(cp);
-}
-
-void
-MuxingKvmGic::unserialize(CheckpointIn &cp)
-{
- Pl390::unserialize(cp);
-}
-
Tick
MuxingKvmGic::read(PacketPtr pkt)
{
diff --git a/src/arch/arm/kvm/gic.hh b/src/arch/arm/kvm/gic.hh
index 5447e6a..a2a62cd 100644
--- a/src/arch/arm/kvm/gic.hh
+++ b/src/arch/arm/kvm/gic.hh
@@ -174,15 +174,10 @@
MuxingKvmGic(const MuxingKvmGicParams *p);
~MuxingKvmGic();
- void loadState(CheckpointIn &cp) override;
-
void startup() override;
DrainState drain() override;
void drainResume() override;
- void serialize(CheckpointOut &cp) const override;
- void unserialize(CheckpointIn &cp) override;
-
public: // PioDevice
Tick read(PacketPtr pkt) override;
Tick write(PacketPtr pkt) override;
--
To view, visit https://gem5-review.googlesource.com/4760
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84aae13d4966df0f4fdd1a72aee0bf1af01392ff
Gerrit-Change-Number: 4760
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
