Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/4821
to review the following change.
Change subject: cpu-o3: Check predication before the SQ size for a debug
print
......................................................................
cpu-o3: Check predication before the SQ size for a debug print
The size of the store entry in the LSQ is used to indicate a fault in
the execution of the store. At the same time, a store that is
predicated false will also have 0 size in the corresponding store
queue entry. This changeset ensures that we check if the store was
predicated false before checking the size field. This way we avoid
printing stores as faulting when they are only predicated false.
Change-Id: Ie07982197bd73d7b44d26a3257d54ecb103a952a
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/cpu/o3/lsq_unit_impl.hh
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/cpu/o3/lsq_unit_impl.hh b/src/cpu/o3/lsq_unit_impl.hh
index 65abaa4..ca6a7f3 100644
--- a/src/cpu/o3/lsq_unit_impl.hh
+++ b/src/cpu/o3/lsq_unit_impl.hh
@@ -679,18 +679,18 @@
store_fault == NoFault)
return store_fault;
- if (!store_inst->readPredicate())
+ if (!store_inst->readPredicate()) {
+ DPRINTF(LSQUnit, "Store [sn:%lli] not executed from predication\n",
+ store_inst->seqNum);
store_inst->forwardOldRegs();
+ return store_fault;
+ }
if (storeQueue[store_idx].size == 0) {
DPRINTF(LSQUnit,"Fault on Store PC %s, [sn:%lli], Size = 0\n",
store_inst->pcState(), store_inst->seqNum);
return store_fault;
- } else if (!store_inst->readPredicate()) {
- DPRINTF(LSQUnit, "Store [sn:%lli] not executed from predication\n",
- store_inst->seqNum);
- return store_fault;
}
assert(store_fault == NoFault);
--
To view, visit https://gem5-review.googlesource.com/4821
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie07982197bd73d7b44d26a3257d54ecb103a952a
Gerrit-Change-Number: 4821
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
