Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/6881
to review the following change.
Change subject: arch-arm: Fix StaticInst encoding() method
......................................................................
arch-arm: Fix StaticInst encoding() method
The previously introduced method was missing the machInst value
to be masked.
Change-Id: Ic722f7cc2abc680da1a1f19c08299338b5c859a6
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Chuan Zhu <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/arch/arm/insts/static_inst.hh
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/arm/insts/static_inst.hh
b/src/arch/arm/insts/static_inst.hh
index 4595646..7ca1a84 100644
--- a/src/arch/arm/insts/static_inst.hh
+++ b/src/arch/arm/insts/static_inst.hh
@@ -440,7 +440,7 @@
MachInst
encoding() const
{
- return static_cast<MachInst>(mask(instSize() * 8));
+ return static_cast<MachInst>(machInst & (mask(instSize() * 8)));
}
};
}
--
To view, visit https://gem5-review.googlesource.com/6881
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic722f7cc2abc680da1a1f19c08299338b5c859a6
Gerrit-Change-Number: 6881
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
