Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/7162
to review the following change.
Change subject: mem-ruby: Remove function that maps responses to a DMA
engine
......................................................................
mem-ruby: Remove function that maps responses to a DMA engine
The function map_Address_to_DMA was used to route responses to the
first (and assumed to be the only) DMA engine in the system. This
function is now unused as protocols handle responses and route them to
the right DMA engine.
Change-Id: I2fba913cf2f12321d1a1e38e7ee85bdf26b8a47a
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/mem/protocol/RubySlicc_ComponentMapping.sm
M src/mem/slicc/symbols/Type.py
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/src/mem/protocol/RubySlicc_ComponentMapping.sm
b/src/mem/protocol/RubySlicc_ComponentMapping.sm
index 673c99f..c6b30ed 100644
--- a/src/mem/protocol/RubySlicc_ComponentMapping.sm
+++ b/src/mem/protocol/RubySlicc_ComponentMapping.sm
@@ -35,7 +35,6 @@
MachineID mapAddressToRange(Addr addr, MachineType type,
int low, int high, NodeID n);
NetDest broadcast(MachineType type);
-MachineID map_Address_to_DMA(Addr addr);
NodeID machineIDToNodeID(MachineID machID);
NodeID machineIDToVersion(MachineID machID);
MachineType machineIDToMachineType(MachineID machID);
diff --git a/src/mem/slicc/symbols/Type.py b/src/mem/slicc/symbols/Type.py
index 188d6dd..37c0b16 100644
--- a/src/mem/slicc/symbols/Type.py
+++ b/src/mem/slicc/symbols/Type.py
@@ -523,10 +523,6 @@
''')
for enum in self.enums.itervalues():
- if enum.ident == "DMA":
- code('''
-MachineID map_Address_to_DMA(const Addr &addr);
-''')
code('''
MachineID get${{enum.ident}}MachineID(NodeID RubyNode);
@@ -774,16 +770,6 @@
''')
for enum in self.enums.itervalues():
- if enum.ident == "DMA":
- code('''
-MachineID
-map_Address_to_DMA(const Addr &addr)
-{
- MachineID dma = {MachineType_DMA, 0};
- return dma;
-}
-''')
-
code('''
MachineID
--
To view, visit https://gem5-review.googlesource.com/7162
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fba913cf2f12321d1a1e38e7ee85bdf26b8a47a
Gerrit-Change-Number: 7162
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
