Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/8282
to review the following change.
Change subject: mem-cache: Remove redundant block initialization on
allocation
......................................................................
mem-cache: Remove redundant block initialization on allocation
Change-Id: I7496e12e6a517529316c480d5f6e2ade601f0e2d
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/mem/cache/tags/base_set_assoc.hh
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/mem/cache/tags/base_set_assoc.hh
b/src/mem/cache/tags/base_set_assoc.hh
index ef4c68b..c1be946 100644
--- a/src/mem/cache/tags/base_set_assoc.hh
+++ b/src/mem/cache/tags/base_set_assoc.hh
@@ -254,12 +254,8 @@
replacements[0]++;
totalRefs += blk->refCount;
++sampledRefs;
- blk->refCount = 0;
- // deal with evicted block
- assert(blk->srcMasterId < cache->system->maxMasters());
- occupancies[blk->srcMasterId]--;
-
+ invalidate(blk);
blk->invalidate();
}
--
To view, visit https://gem5-review.googlesource.com/8282
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7496e12e6a517529316c480d5f6e2ade601f0e2d
Gerrit-Change-Number: 8282
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
