Hello Andreas Sandberg,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/8367

to review the following change.


Change subject: arch-arm: Semihosting not available in syscall emulation
......................................................................

arch-arm: Semihosting not available in syscall emulation

Arm Semihosting is not available in syscall emulation since we don't
have an Arm system in that scenario. Trying to use it in "se" mode will
make getArmSystem assertion fail.

Change-Id: I4cf49ae801ec6e6c93134ac6ae2a0f412040684c
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/arch/arm/system.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/arch/arm/system.cc b/src/arch/arm/system.cc
index caef6dc..a540a63 100644
--- a/src/arch/arm/system.cc
+++ b/src/arch/arm/system.cc
@@ -273,7 +273,7 @@
 bool
 ArmSystem::haveSemihosting(ThreadContext *tc)
 {
-    return getArmSystem(tc)->haveSemihosting();
+    return FullSystem && getArmSystem(tc)->haveSemihosting();
 }

 uint64_t

--
To view, visit https://gem5-review.googlesource.com/8367
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cf49ae801ec6e6c93134ac6ae2a0f412040684c
Gerrit-Change-Number: 8367
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to