Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/9221
Change subject: hsail: Get rid of an inert private member of StorageSpace.
......................................................................
hsail: Get rid of an inert private member of StorageSpace.
The "segment" private element in this class was only ever set to zero
on construction, and then used to index into a list of segment names
to get the string "none" in a DPRINTF. If debugging was turned off,
there would be no consumers of that variable, and that upset g++. This
change removes the essentially useless variable, and also that bit of
text in the DPRINTF.
Change-Id: I3f85db4af5f0678768243daf84b8d698350af931
---
M src/gpu-compute/hsail_code.cc
M src/gpu-compute/hsail_code.hh
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/gpu-compute/hsail_code.cc b/src/gpu-compute/hsail_code.cc
index 59faa67..99f4b38 100644
--- a/src/gpu-compute/hsail_code.cc
+++ b/src/gpu-compute/hsail_code.cc
@@ -305,8 +305,8 @@
nextOffset = offset + size;
- DPRINTF(HSAILObject, "Adding %s SYMBOL %s size %d offset 0x%x,
init: %d\n",
- segmentNames[segment], sym_name, size, offset, sym->init);
+ DPRINTF(HSAILObject, "Adding SYMBOL %s size %d offset %#x, init: %d\n",
+ sym_name, size, offset, sym->init);
StorageElement* se = new StorageElement(sym_name, offset, size, sym);
elements.push_back(se);
diff --git a/src/gpu-compute/hsail_code.hh b/src/gpu-compute/hsail_code.hh
index d9fbcc5..9919461 100644
--- a/src/gpu-compute/hsail_code.hh
+++ b/src/gpu-compute/hsail_code.hh
@@ -245,11 +245,9 @@
DirVarToSE_map elements_by_brigptr;
uint64_t nextOffset;
- Brig::BrigSegment segment;
public:
- StorageSpace(Brig::BrigSegment _class)
- : nextOffset(0), segment(_class)
+ StorageSpace(Brig::BrigSegment _class) : nextOffset(0)
{
}
--
To view, visit https://gem5-review.googlesource.com/9221
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3f85db4af5f0678768243daf84b8d698350af931
Gerrit-Change-Number: 9221
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
