Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/9401 )
Change subject: cpu: Stop extracting inst_flags from the machInst.
......................................................................
cpu: Stop extracting inst_flags from the machInst.
The instruction representation is already encoded in the trace
protobuf, so there's no reason to encode a part of it again. This is
especially true since this supposedly generic code is extracting the
first 8 bits of the machInst, a totally arbitrary set of bits for most
ISAs. If certain bits within a machine instruction are actually
relevant, the consumer of the trace should be able to interpret the
instruction bytes which are already there and extract the same bits
within the context of whatever ISA they're appropriate for.
Change-Id: Idaebe6a110d7d4812c3d7c434582d5a9470bcec1
Reviewed-on: https://gem5-review.googlesource.com/9401
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/cpu/inst_pb_trace.cc
M src/proto/inst.proto
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Gabe Black: Looks good to me, approved
diff --git a/src/cpu/inst_pb_trace.cc b/src/cpu/inst_pb_trace.cc
index 138ef53..4c8d2f6 100644
--- a/src/cpu/inst_pb_trace.cc
+++ b/src/cpu/inst_pb_trace.cc
@@ -160,8 +160,6 @@
curMsg->set_cpuid(tc->cpuId());
curMsg->set_tick(curTick());
curMsg->set_type(static_cast<ProtoMessage::Inst_InstType>(si->opClass()));
- curMsg->set_inst_flags(bits(si->machInst, 7, 0));
-
}
void
diff --git a/src/proto/inst.proto b/src/proto/inst.proto
index 2a5dd95..ef44dfe 100644
--- a/src/proto/inst.proto
+++ b/src/proto/inst.proto
@@ -101,6 +101,8 @@
}
optional InstType type = 6; // add, mul, fp add, load, store, simd add, …
+
+ // Deprecated:
optional uint32 inst_flags = 7; // execution mode information
// If the operation does one or more memory accesses
--
To view, visit https://gem5-review.googlesource.com/9401
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Idaebe6a110d7d4812c3d7c434582d5a9470bcec1
Gerrit-Change-Number: 9401
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
