Hello Andreas Sandberg,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/9501

to review the following change.


Change subject: arch-arm: Correct mcrr,mrrc disassemble
......................................................................

arch-arm: Correct mcrr,mrrc disassemble

This patch is fixing AArch32 mcrr,mrrc instruction disassemble by
printing the correct source/destination registers

Change-Id: I3fcffa0349aeee466e7c60ba4d1244824fb65d91
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/arch/arm/insts/misc.cc
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/arch/arm/insts/misc.cc b/src/arch/arm/insts/misc.cc
index 9c7a051..d4a2ba2 100644
--- a/src/arch/arm/insts/misc.cc
+++ b/src/arch/arm/insts/misc.cc
@@ -153,7 +153,7 @@
     ss << ", ";
     printIntReg(ss, dest2);
     ss << ", ";
-    printIntReg(ss, op1);
+    printMiscReg(ss, op1);
     return ss.str();
 }

@@ -162,7 +162,7 @@
 {
     std::stringstream ss;
     printMnemonic(ss);
-    printIntReg(ss, dest);
+    printMiscReg(ss, dest);
     ss << ", ";
     printIntReg(ss, op1);
     ss << ", ";

--
To view, visit https://gem5-review.googlesource.com/9501
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3fcffa0349aeee466e7c60ba4d1244824fb65d91
Gerrit-Change-Number: 9501
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to