Anthony Gutierrez has submitted this change and it was merged. (
https://gem5-review.googlesource.com/8521 )
Change subject: ruby,gpu-compute: bugfix for GPU_VIPER* protocols
......................................................................
ruby,gpu-compute: bugfix for GPU_VIPER* protocols
12db50c895 changed how directory mapping works, but it seems to have
broken the VIPER variants of the GPU protocols. The fix involves
declaring the function in the related '.sm' files.
Change-Id: I116980d42a4aa648369058b529c9f8d9693eb894
Reviewed-on: https://gem5-review.googlesource.com/8521
Reviewed-by: Anthony Gutierrez <anthony.gutier...@amd.com>
Reviewed-by: Jason Lowe-Power <ja...@lowepower.com>
Maintainer: Anthony Gutierrez <anthony.gutier...@amd.com>
---
M src/mem/protocol/GPU_VIPER-TCC.sm
M src/mem/protocol/GPU_VIPER_Region-TCC.sm
M src/mem/protocol/MOESI_AMD_Base-Region-dir.sm
3 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Anthony Gutierrez: Looks good to me, approved; Looks good to me, approved
diff --git a/src/mem/protocol/GPU_VIPER-TCC.sm
b/src/mem/protocol/GPU_VIPER-TCC.sm
index 45477d8..f8da4ab 100644
--- a/src/mem/protocol/GPU_VIPER-TCC.sm
+++ b/src/mem/protocol/GPU_VIPER-TCC.sm
@@ -126,6 +126,7 @@
void wakeUpAllBuffers();
void wakeUpBuffers(Addr a);
+ MachineID mapAddressToMachine(Addr addr, MachineType mtype);
// FUNCTION DEFINITIONS
Tick clockEdge();
diff --git a/src/mem/protocol/GPU_VIPER_Region-TCC.sm
b/src/mem/protocol/GPU_VIPER_Region-TCC.sm
index e3243b3..04d7b7a 100644
--- a/src/mem/protocol/GPU_VIPER_Region-TCC.sm
+++ b/src/mem/protocol/GPU_VIPER_Region-TCC.sm
@@ -131,6 +131,7 @@
void wakeUpAllBuffers();
void wakeUpBuffers(Addr a);
+ MachineID mapAddressToMachine(Addr addr, MachineType mtype);
// FUNCTION DEFINITIONS
diff --git a/src/mem/protocol/MOESI_AMD_Base-Region-dir.sm
b/src/mem/protocol/MOESI_AMD_Base-Region-dir.sm
index 02b2118..cc5ceb0 100644
--- a/src/mem/protocol/MOESI_AMD_Base-Region-dir.sm
+++ b/src/mem/protocol/MOESI_AMD_Base-Region-dir.sm
@@ -210,6 +210,8 @@
void wakeUpBuffers(Addr a);
Cycles curCycle();
+ MachineID mapAddressToMachine(Addr addr, MachineType mtype);
+
Entry getDirectoryEntry(Addr addr), return_by_pointer="yes" {
Entry dir_entry := static_cast(Entry, "pointer",
directory.lookup(addr));
--
To view, visit https://gem5-review.googlesource.com/8521
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I116980d42a4aa648369058b529c9f8d9693eb894
Gerrit-Change-Number: 8521
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Potter <brandon.pot...@amd.com>
Gerrit-Reviewer: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Bradford Beckmann <brad.beckm...@amd.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
