Anthony Gutierrez has uploaded this change for review. (
https://gem5-review.googlesource.com/10001
Change subject: gpu-compute: fix bad asserts in gpu tlb and cu tlb port
......................................................................
gpu-compute: fix bad asserts in gpu tlb and cu tlb port
change 2a15bfd79ced20a6d4cbf0a0a4c2fbb1444b9a44 introduced
a few bugs in the tlb of the cu. asserts in the gpu tlb
and cu expected the page table lookup() function to return
a bool, and this value was used directly in the gpu tlb's
assert and it was kept in the gpu tlb entry, where later
the cu would assert that it is true.
this change fixes the issue by checking the validity of
the pte pointer returned by lookup() in order to set
the validity of the tlb entry itself.
Change-Id: Ief1f205db65f1911fd132acd314e4407c5e3ffdf
---
M src/gpu-compute/gpu_tlb.cc
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gpu-compute/gpu_tlb.cc b/src/gpu-compute/gpu_tlb.cc
index 05d22da..5691f35 100644
--- a/src/gpu-compute/gpu_tlb.cc
+++ b/src/gpu-compute/gpu_tlb.cc
@@ -1544,14 +1544,14 @@
if (!sender_state->prefetch) {
// no PageFaults are permitted after
// the second page table lookup
- assert(success);
+ assert(pte);
DPRINTF(GPUTLB, "Mapping %#x to %#x\n", alignedVaddr,
pte->paddr);
sender_state->tlbEntry =
new GpuTlbEntry(0, virt_page_addr,
- pte->paddr, success);
+ pte->paddr, true);
} else {
// If this was a prefetch, then do the normal thing if
it
// was a successful translation. Otherwise, send an
empty
@@ -1563,7 +1563,7 @@
sender_state->tlbEntry =
new GpuTlbEntry(0, virt_page_addr,
- pte->paddr, success);
+ pte->paddr, true);
} else {
DPRINTF(GPUPrefetch, "Prefetch failed %#x\n",
alignedVaddr);
--
To view, visit https://gem5-review.googlesource.com/10001
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ief1f205db65f1911fd132acd314e4407c5e3ffdf
Gerrit-Change-Number: 10001
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
