Hello Nikos Nikoleris, Curtis Dunham,

I'd like you to do a code review. Please visit

    https://gem5-review.googlesource.com/10042

to review the following change.


Change subject: arch-arm: Adding MiscReg Priv (EL1) global flag
......................................................................

arch-arm: Adding MiscReg Priv (EL1) global flag

This patch introduces a single global flag for setting RW access
permission at EL1 level, in either secure and non-secure mode.

Change-Id: I35df66a73349044ca996b5c04c5a2476f3a7abdf
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Curtis Dunham <[email protected]>
---
M src/arch/arm/isa.hh
1 file changed, 10 insertions(+), 0 deletions(-)



diff --git a/src/arch/arm/isa.hh b/src/arch/arm/isa.hh
index c10a88a..c8ae5c2 100644
--- a/src/arch/arm/isa.hh
+++ b/src/arch/arm/isa.hh
@@ -199,6 +199,11 @@
                 info[MISCREG_PRI_NS_WR] = v;
                 return *this;
             }
+            chain privNonSecure(bool v = true) const {
+                privNonSecureRead(v);
+                privNonSecureWrite(v);
+                return *this;
+            }
             chain privSecureRead(bool v = true) const {
                 info[MISCREG_PRI_S_RD] = v;
                 return *this;
@@ -212,6 +217,11 @@
                 privSecureWrite(v);
                 return *this;
             }
+            chain priv(bool v = true) const {
+                privSecure(v);
+                privNonSecure(v);
+                return *this;
+            }
             chain hypRead(bool v = true) const {
                 info[MISCREG_HYP_RD] = v;
                 return *this;

--
To view, visit https://gem5-review.googlesource.com/10042
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I35df66a73349044ca996b5c04c5a2476f3a7abdf
Gerrit-Change-Number: 10042
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to