Hello Ciro Santilli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/11036
to review the following change.
Change subject: system-arm: Add a device tree for the VExpress_GEM5_V1_DPU
......................................................................
system-arm: Add a device tree for the VExpress_GEM5_V1_DPU
The new platform needs a new device tree. Like the HDLCD-based
platform, the DPU is disabled by default since it requires display
timings to be specified separately.
Change-Id: I4cb357ab6e08d129b3e0d998ffc7e5d1415e94e4
Signed-off-by: Andreas Sandberg <[email protected]>
Reviewed-by: Ciro Santilli <[email protected]>
---
M system/arm/dt/Makefile
A system/arm/dt/platforms/vexpress_gem5_v1_dpu.dtsi
2 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/system/arm/dt/Makefile b/system/arm/dt/Makefile
index a162b9f..7371e49 100644
--- a/system/arm/dt/Makefile
+++ b/system/arm/dt/Makefile
@@ -39,7 +39,12 @@
armv8_gem5_v1_4cpu.dtb armv8_gem5_v1_8cpu.dtb \
armv8_gem5_v1_16cpu.dtb \
armv8_gem5_v1_big_little_2_2.dtb \
- armv8_gem5_v1_big_little_2_4.dtb
+ armv8_gem5_v1_big_little_2_4.dtb \
+ \
+ armv7_gem5_v1_dpu_1cpu.dtb armv7_gem5_v1_dpu_2cpu.dtb \
+ armv7_gem5_v1_dpu_4cpu.dtb armv7_gem5_v1_dpu_8cpu.dtb \
+ armv8_gem5_v1_dpu_1cpu.dtb armv8_gem5_v1_dpu_2cpu.dtb \
+ armv8_gem5_v1_dpu_4cpu.dtb armv8_gem5_v1_dpu_8cpu.dtb
GEN_DTS=mkdir -p .gen; \
$(CPP) -x assembler-with-cpp \
@@ -51,6 +56,13 @@
all: $(TARGETS)
platforms/vexpress_gem5_v1.dtsi: platforms/vexpress_gem5_v1_base.dtsi
+platforms/vexpress_gem5_v1_dpu.dtsi: platforms/vexpress_gem5_v1_base.dtsi
+
+.gen/armv7_gem5_v1_dpu_%cpu.dts: armv7.dts
platforms/vexpress_gem5_v1_dpu.dtsi
+ $(call GEN_DTS,vexpress_gem5_v1_dpu.dtsi,$*)
+
+.gen/armv8_gem5_v1_dpu_%cpu.dts: armv8.dts
platforms/vexpress_gem5_v1_dpu.dtsi
+ $(call GEN_DTS,vexpress_gem5_v1_dpu.dtsi,$*)
.gen/armv7_gem5_v1_%cpu.dts: armv7.dts platforms/vexpress_gem5_v1.dtsi
$(call GEN_DTS,vexpress_gem5_v1.dtsi,$*)
diff --git a/system/arm/dt/platforms/vexpress_gem5_v1_dpu.dtsi
b/system/arm/dt/platforms/vexpress_gem5_v1_dpu.dtsi
new file mode 100644
index 0000000..6f48ca8
--- /dev/null
+++ b/system/arm/dt/platforms/vexpress_gem5_v1_dpu.dtsi
@@ -0,0 +1,50 @@
+/*
+ * Copyright (c) 2015-2016, 2018 ARM Limited
+ * All rights reserved
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ * redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution;
+ * neither the name of the copyright holders nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Authors: Andreas Sandberg
+ */
+
+#include "vexpress_gem5_v1_base.dtsi"
+
+/ {
+ /* The display processor needs custom configuration to setup its
+ * output ports. Disable it by default in the platform until the
+ * DT bindings have stabilize.
+ */
+ dp0: malidp@2b000000 {
+ compatible = "arm,mali-dp650";
+
+ reg = <0 0x2b000000 0 0x20000>;
+ interrupts = <0 63 4>, <0 64 4>;
+ interrupt-names = "DE", "SE";
+ clocks = <&osc_pxl>, <&osc_pxl>, <&osc_sys>, <&osc_sys>;
+ clock-names = "pxlclk", "mclk", "aclk", "pclk";
+ arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+
+ status = "disabled";
+ };
+};
--
To view, visit https://gem5-review.googlesource.com/11036
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4cb357ab6e08d129b3e0d998ffc7e5d1415e94e4
Gerrit-Change-Number: 11036
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
