Hi Jason, thanks for making sure everybody has a chance to chime in. I haven't looked at the changes in a while, but I'm also comfortable with them going in without looking them over again given that other people have +2-ed them, the high likelihood it will improve on the status quo, and that we should be able to fix any serious emergent problems as they become apparent. Thanks for keeping this going!
Gabe On Thu, Jul 5, 2018 at 1:23 PM Jason Lowe-Power <[email protected]> wrote: > Hi all, > > I'm hoping that we can finalize the new testing framework, and I can push > it in within the next week or so. All of the important changes have at > least one +2, but I want to give everyone one last chance to object or > suggest changes. I've been talking to Sean, and while there's more that > could be cleaned up in ext/testlib, we think it's good as it is. At a > minimum, this will give us a starting point. I'd like to get this in soon > so I can start adding more tests to it in the coming weeks. > > The patches are linked below: > > https://gem5-review.googlesource.com/c/public/gem5/+/4880/7 > https://gem5-review.googlesource.com/c/public/gem5/+/4881/7 > https://gem5-review.googlesource.com/c/public/gem5/+/4421/12 > https://gem5-review.googlesource.com/c/public/gem5/+/4882/13 > https://gem5-review.googlesource.com/c/public/gem5/+/4883/13 > https://gem5-review.googlesource.com/c/public/gem5/+/4422/13 > https://gem5-review.googlesource.com/c/public/gem5/+/4423/13 > https://gem5-review.googlesource.com/c/public/gem5/+/10121/4 > > Thanks, > Jason > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
