Bradley Wang has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/11871 )
Change subject: base: Replace cppversion == version with >= version
......................................................................
base: Replace cppversion == version with >= version
For forward compatibility with later compilers, we should have a greater
than comparison instead of an explicit equality with a particular C++
version.
Change-Id: If848097420b9575f80134986410da3dab32567da
Signed-off-by: Bradley Wang <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/11871
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/base/compiler.hh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Gabe Black: Looks good to me, approved; Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
diff --git a/src/base/compiler.hh b/src/base/compiler.hh
index 35156ee..957ef40 100644
--- a/src/base/compiler.hh
+++ b/src/base/compiler.hh
@@ -92,7 +92,7 @@
namespace m5
{
-#if __cplusplus == 201402L // C++14
+#if __cplusplus >= 201402L // C++14
using std::make_unique;
@@ -108,7 +108,7 @@
);
}
-#endif // __cplusplus == 201402L
+#endif // __cplusplus >= 201402L
} //namespace m5
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/11871
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If848097420b9575f80134986410da3dab32567da
Gerrit-Change-Number: 11871
Gerrit-PatchSet: 4
Gerrit-Owner: Bradley Wang <[email protected]>
Gerrit-Reviewer: Bradley Wang <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
