Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/10957 )
Change subject: systemc: Add a non-standard default writer policy on
sc_buffer.
......................................................................
systemc: Add a non-standard default writer policy on sc_buffer.
The standard says there's not supposed to be a default writer policy
for the sc_buffer template class, but in the Accellera implementation
there is, and the regression tests depend on it to compile.
Change-Id: I31d17617441224e86c56c54e45364be8f4f45b00
Reviewed-on: https://gem5-review.googlesource.com/10957
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/systemc/ext/channel/sc_buffer.hh
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/ext/channel/sc_buffer.hh
b/src/systemc/ext/channel/sc_buffer.hh
index 153b60b..2208160 100644
--- a/src/systemc/ext/channel/sc_buffer.hh
+++ b/src/systemc/ext/channel/sc_buffer.hh
@@ -37,7 +37,9 @@
namespace sc_core
{
-template <class T, sc_writer_policy WRITER_POLICY>
+// Having a default value for the WRITER_POLICY parameter is non-standard,
but
+// matches the Accellera implementation to enable the regression tests.
+template <class T, sc_writer_policy WRITER_POLICY=SC_ONE_WRITER>
class sc_buffer : public sc_signal<T, WRITER_POLICY>
{
public:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/10957
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I31d17617441224e86c56c54e45364be8f4f45b00
Gerrit-Change-Number: 10957
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
