Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/12254
to look at the new patch set (#2).
Change subject: systemc: Make the test config retrieve sc_main results.
......................................................................
systemc: Make the test config retrieve sc_main results.
Accellera's implementation prints any sc_report which is thrown and
escapes sc_main, so we need to do the same to make some tests pass.
Arguably gem5 should fail if sc_main reports an error, but verify.py
would interpret that as the test failing too, and some tests
purposefully generate errors.
This change also stops using the logging module. It wasn't really
providing any benefit, and added extra decoration to log messages
which confused verify.py.
Change-Id: I6850d0ada5e477b67527d99d421478586cda93b3
---
M src/systemc/tests/config.py
1 file changed, 12 insertions(+), 3 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12254
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I6850d0ada5e477b67527d99d421478586cda93b3
Gerrit-Change-Number: 12254
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
