Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/12043 )
Change subject: systemc: Promote some functions to sc_export_base.
......................................................................
systemc: Promote some functions to sc_export_base.
There are a few functions which return a generic sc_interface pointer
which were (in the spec) defined to be in the interface type specific
sc_export class. They don't need to be and aren't in the Accellera
implementation, and without having them in the base class there's no
good way to get at a generic interface pointer from an export.
Change-Id: Iba692c79bf1d4f7684f28447d8b22c88ef4b804d
Reviewed-on: https://gem5-review.googlesource.com/12043
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/systemc/ext/core/sc_export.hh
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/ext/core/sc_export.hh
b/src/systemc/ext/core/sc_export.hh
index dc21764..421e063 100644
--- a/src/systemc/ext/core/sc_export.hh
+++ b/src/systemc/ext/core/sc_export.hh
@@ -41,6 +41,9 @@
{
public:
void warn_unimpl(const char *func) const;
+
+ virtual sc_interface *get_iterface() = 0;
+ virtual const sc_interface *get_interface() const = 0;
};
template <class IF>
@@ -71,14 +74,14 @@
return nullptr;
}
- virtual sc_interface *
- get_iterface()
+ sc_interface *
+ get_iterface() override
{
warn_unimpl(__PRETTY_FUNCTION__);
return nullptr;
}
- virtual const sc_interface *
- get_interface() const
+ const sc_interface *
+ get_interface() const override
{
warn_unimpl(__PRETTY_FUNCTION__);
return nullptr;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12043
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Iba692c79bf1d4f7684f28447d8b22c88ef4b804d
Gerrit-Change-Number: 12043
Gerrit-PatchSet: 8
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
