Xianwei Zhang has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/12784
Change subject: mem-ruby: Fix a bug in MessageBuffer randomization
......................................................................
mem-ruby: Fix a bug in MessageBuffer randomization
In the previous implementation, messages are randomly inserted with
delays only if both RubySystem and buffer randomization are set true,
which is certainly undesired (e.g., ruby random tester cannot turn on
randomization by just setting 'system.ruby.randomization = True".)
As a fix, this patch enables randomization when either RubySystem or
buffer is set.
Change-Id: I1e076908ff07e5846ebad4f4fc1c8f28d40bbfd4
---
M src/mem/ruby/network/MessageBuffer.cc
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mem/ruby/network/MessageBuffer.cc
b/src/mem/ruby/network/MessageBuffer.cc
index f4eca3b..024637c 100644
--- a/src/mem/ruby/network/MessageBuffer.cc
+++ b/src/mem/ruby/network/MessageBuffer.cc
@@ -156,7 +156,7 @@
assert(delta > 0);
Tick arrival_time = 0;
- if (!RubySystem::getRandomization() || !m_randomization) {
+ if (!RubySystem::getRandomization() && !m_randomization) {
// No randomization
arrival_time = current_time + delta;
} else {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12784
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I1e076908ff07e5846ebad4f4fc1c8f28d40bbfd4
Gerrit-Change-Number: 12784
Gerrit-PatchSet: 1
Gerrit-Owner: Xianwei Zhang <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
