Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/12072 )
Change subject: systemc: "Implement" sc_interface's methods.
......................................................................
systemc: "Implement" sc_interface's methods.
Most don't do anything. Make default_event() return a dummy event to
avoid dereferencing a null pointer.
Change-Id: I8d6d576d3a1f585029c387cd414bbebf2d670644
Reviewed-on: https://gem5-review.googlesource.com/12072
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/systemc/core/sc_interface.cc
M src/systemc/ext/core/sc_interface.hh
2 files changed, 5 insertions(+), 21 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/core/sc_interface.cc
b/src/systemc/core/sc_interface.cc
index e01bdcc..171422d 100644
--- a/src/systemc/core/sc_interface.cc
+++ b/src/systemc/core/sc_interface.cc
@@ -28,32 +28,17 @@
*/
#include "base/logging.hh"
+#include "systemc/ext/core/sc_event.hh"
#include "systemc/ext/core/sc_interface.hh"
namespace sc_core
{
-void
-sc_interface::register_port(sc_port_base &, const char *)
-{
- warn("%s not implemented.\n", __PRETTY_FUNCTION__);
-}
-
const sc_event &
sc_interface::default_event() const
{
- warn("%s not implemented.\n", __PRETTY_FUNCTION__);
- return *(sc_event *)nullptr;
-}
-
-sc_interface::~sc_interface()
-{
- warn("%s not implemented.\n", __PRETTY_FUNCTION__);
-}
-
-sc_interface::sc_interface()
-{
- warn("%s not implemented.\n", __PRETTY_FUNCTION__);
+ static sc_event dummy;
+ return dummy;
}
} // namespace sc_core
diff --git a/src/systemc/ext/core/sc_interface.hh
b/src/systemc/ext/core/sc_interface.hh
index 2073f53..3c6a27d 100644
--- a/src/systemc/ext/core/sc_interface.hh
+++ b/src/systemc/ext/core/sc_interface.hh
@@ -39,12 +39,11 @@
class sc_interface
{
public:
- virtual void register_port(sc_port_base &, const char *);
virtual const sc_event &default_event() const;
- virtual ~sc_interface();
+ virtual ~sc_interface() {};
protected:
- sc_interface();
+ sc_interface() {};
private:
// Disabled
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12072
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I8d6d576d3a1f585029c387cd414bbebf2d670644
Gerrit-Change-Number: 12072
Gerrit-PatchSet: 9
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
