Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/13005
to review the following change.
Change subject: syscall_emul: fix openat when directory does not end in "/"
......................................................................
syscall_emul: fix openat when directory does not end in "/"
Before this commit, the following code:
dir_fd = open(".", O_DIRECTORY);
file_fd = openat(dir_fd, "ble", O_CREAT, S_IRUSR | S_IWUSR);
would create a file called ".ble" in the current working directory,
instead of the correct "ble".
Change-Id: I1525a088d49744e29b760387afabef9f1ac98646
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/sim/syscall_emul.hh
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sim/syscall_emul.hh b/src/sim/syscall_emul.hh
index c7818b6..17d4109 100644
--- a/src/sim/syscall_emul.hh
+++ b/src/sim/syscall_emul.hh
@@ -695,7 +695,7 @@
auto ffdp = std::dynamic_pointer_cast<FileFDEntry>(fdep);
if (!ffdp)
return -EBADF;
- path.insert(0, ffdp->getFileName());
+ path.insert(0, ffdp->getFileName() + "/");
}
/**
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13005
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I1525a088d49744e29b760387afabef9f1ac98646
Gerrit-Change-Number: 13005
Gerrit-PatchSet: 1
Gerrit-Owner: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
