Daniel Carvalho has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/13208 )
Change subject: mem-cache: Make boundaries in FALRU an STL container
......................................................................
mem-cache: Make boundaries in FALRU an STL container
Turn the dynamically allocated array of pointers "boundaries"
into a STL vector.
Change-Id: I3409898473b155f69b4c6e038eba2dffb5b09380
Signed-off-by: Daniel R. Carvalho <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/13208
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/mem/cache/tags/fa_lru.hh
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
diff --git a/src/mem/cache/tags/fa_lru.hh b/src/mem/cache/tags/fa_lru.hh
index 55362a4..03af572 100644
--- a/src/mem/cache/tags/fa_lru.hh
+++ b/src/mem/cache/tags/fa_lru.hh
@@ -53,6 +53,7 @@
#include <functional>
#include <string>
#include <unordered_map>
+#include <vector>
#include "base/bitfield.hh"
#include "base/intmath.hh"
@@ -272,7 +273,7 @@
numTrackedCaches(max_size > min_size ?
floorLog2(max_size) - floorLog2(min_size) :
0),
inAllCachesMask(mask(numTrackedCaches)),
- boundaries(new FALRUBlk *[numTrackedCaches])
+ boundaries(numTrackedCaches)
{
fatal_if(numTrackedCaches > sizeof(CachesMask) * 8,
"Not enough bits (%s) in type CachesMask type to
keep "
@@ -280,11 +281,6 @@
numTrackedCaches);
}
- ~CacheTracking()
- {
- delete[] boundaries;
- }
-
/**
* Initialiaze cache blocks and the tracking mechanism
*
@@ -356,7 +352,7 @@
/** A mask for all cache being tracked. */
const CachesMask inAllCachesMask;
/** Array of pointers to blocks at the cache boundaries. */
- FALRUBlk** boundaries;
+ std::vector<FALRUBlk*> boundaries;
protected:
/**
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13208
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I3409898473b155f69b4c6e038eba2dffb5b09380
Gerrit-Change-Number: 13208
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
