Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/13200
to look at the new patch set (#3).
Change subject: systemc: Implement register_port in all the predefined
channels.
......................................................................
systemc: Implement register_port in all the predefined channels.
Something the Accellera implementation does which would be good to do
in the gem5 implementation is to create a base class for sc_signal
which isn't templated, and which holds the common/non-type specific
versions of the various sc_signal methods. This will reduce code
redundancy and binary size, and also let us hide more code in .cc
files so that it's less likely we'd need to recompile model code to
fix a bug.
Also, since this all uses of sc_channel_warn_unimple have now been
eliminated, remove that function.
Change-Id: Ia574647c034e7136093c2047b69de725ac34f52f
---
M src/systemc/channel/SConscript
D src/systemc/channel/warn_unimpl.cc
M src/systemc/ext/channel/sc_fifo.hh
M src/systemc/ext/channel/sc_signal.hh
M src/systemc/ext/channel/sc_signal_rv.hh
D src/systemc/ext/channel/warn_unimpl.hh
A
src/systemc/tests/systemc/communication/sc_signal/check_writer/test08/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/check_writer/test09/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/check_writer/test10/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/check_writer/test11/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/check_writer/test12/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/register_port/test01/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/register_port/test02/expected_returncode
A
src/systemc/tests/systemc/communication/sc_signal/register_port/test03/expected_returncode
14 files changed, 117 insertions(+), 110 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13200
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ia574647c034e7136093c2047b69de725ac34f52f
Gerrit-Change-Number: 13200
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
