Hello Jason Lowe-Power, Matthias Jung, Giacomo Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/13199
to look at the new patch set (#3).
Change subject: systemc: Add missing sc_interface::register_port, and add
calls to it.
......................................................................
systemc: Add missing sc_interface::register_port, and add calls to it.
This function is standard and supposed to be on sc_interface, but it
was somehow left out. This change adds it, and makes sure it's called
by the port binding code. The default implementation does nothing, as
it's supposed to according to the spec.
Also note that only the ports farthest from the interfaces are suppose
to call register_port. As the port bindings are completed, we keep
track of whether a port has been bound to another port. If it has, the
source port is farther from the interfaces than the target port (since
it has to go "through" the target port to get to them, and so the
target port should not call register_port.
Change-Id: Ia98f9ff364385fd1699d88a1d99787d205816a08
---
M src/systemc/core/kernel.cc
M src/systemc/core/port.cc
M src/systemc/core/port.hh
M src/systemc/core/sc_interface.cc
M src/systemc/ext/core/sc_interface.hh
M src/systemc/ext/core/sc_port.hh
6 files changed, 27 insertions(+), 1 deletion(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13199
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ia98f9ff364385fd1699d88a1d99787d205816a08
Gerrit-Change-Number: 13199
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
