Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/13465
Change subject: mem: Delete the packet accessors which use guest endianness.
......................................................................
mem: Delete the packet accessors which use guest endianness.
These accessors create an extra dependency on the guest OS, and can be
avoided. Now that all their uses have been removed, they aren't needed
any more.
Change-Id: I466c07fef99bce2d7964c07a7ac3dd398691378b
---
M src/mem/packet.hh
M src/mem/packet_access.hh
2 files changed, 9 insertions(+), 32 deletions(-)
diff --git a/src/mem/packet.hh b/src/mem/packet.hh
index 515dcc7..dc473c3 100644
--- a/src/mem/packet.hh
+++ b/src/mem/packet.hh
@@ -1055,13 +1055,6 @@
template <typename T>
T get(ByteOrder endian) const;
- /**
- * Get the data in the packet byte swapped from guest to host
- * endian.
- */
- template <typename T>
- T get() const;
-
/** Set the value in the data pointer to v as big endian. */
template <typename T>
void setBE(T v);
@@ -1077,12 +1070,6 @@
template <typename T>
void set(T v, ByteOrder endian);
-#if THE_ISA != NULL_ISA
- /** Set the value in the data pointer to v as guest endian. */
- template <typename T>
- void set(T v);
-#endif
-
/**
* Get the data in the packet byte swapped from the specified
diff --git a/src/mem/packet_access.hh b/src/mem/packet_access.hh
index 92752a7..0b53268 100644
--- a/src/mem/packet_access.hh
+++ b/src/mem/packet_access.hh
@@ -42,14 +42,18 @@
* Andreas Sandberg
*/
-#include "arch/isa_traits.hh"
-#include "config/the_isa.hh"
-#include "mem/packet.hh"
-#include "sim/byteswap.hh"
-
#ifndef __MEM_PACKET_ACCESS_HH__
#define __MEM_PACKET_ACCESS_HH__
+#include "config/the_isa.hh"
+
+#if THE_ISA != NULL_ISA
+#include "arch/isa_traits.hh"
+#endif
+
+#include "mem/packet.hh"
+#include "sim/byteswap.hh"
+
template <typename T>
inline T
Packet::getRaw() const
@@ -100,13 +104,6 @@
}
template <typename T>
-inline T
-Packet::get() const
-{
- return TheISA::gtoh(getRaw<T>());
-}
-
-template <typename T>
inline void
Packet::setBE(T v)
{
@@ -136,11 +133,4 @@
};
}
-template <typename T>
-inline void
-Packet::set(T v)
-{
- setRaw(TheISA::htog(v));
-}
-
#endif //__MEM_PACKET_ACCESS_HH__
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13465
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I466c07fef99bce2d7964c07a7ac3dd398691378b
Gerrit-Change-Number: 13465
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
