Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/12814 )
Change subject: systemc: Change an error message to match the reference
outputs.
......................................................................
systemc: Change an error message to match the reference outputs.
This is different from the message the Accellera implementation would
print, so it looks like it wouldn't pass this test as is.
Change-Id: I0286fd3e3df7bc3e87f38c35086a32d8dec0bcc9
Reviewed-on: https://gem5-review.googlesource.com/c/12814
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/systemc/channel/sc_in_resolved.cc
M src/systemc/channel/sc_inout_resolved.cc
M src/systemc/ext/channel/sc_inout_rv.hh
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/systemc/channel/sc_in_resolved.cc
b/src/systemc/channel/sc_in_resolved.cc
index 40190c8..94cb55a 100644
--- a/src/systemc/channel/sc_in_resolved.cc
+++ b/src/systemc/channel/sc_in_resolved.cc
@@ -47,7 +47,7 @@
{
sc_in<sc_dt::sc_logic>::end_of_elaboration();
if (!dynamic_cast<sc_signal_resolved *>(get_interface())) {
- std::string msg = csprintf("%s (%s)", name(), kind());
+ std::string msg = csprintf("port '%s' (%s)", name(), kind());
SC_REPORT_ERROR("(E117) resolved port not bound to resolved
signal",
msg.c_str());
}
diff --git a/src/systemc/channel/sc_inout_resolved.cc
b/src/systemc/channel/sc_inout_resolved.cc
index 8355a88..2f3dd18 100644
--- a/src/systemc/channel/sc_inout_resolved.cc
+++ b/src/systemc/channel/sc_inout_resolved.cc
@@ -48,7 +48,7 @@
{
sc_inout<sc_dt::sc_logic>::end_of_elaboration();
if (!dynamic_cast<sc_signal_resolved *>(get_interface())) {
- std::string msg = csprintf("%s (%s)", name(), kind());
+ std::string msg = csprintf("port '%s' (%s)", name(), kind());
SC_REPORT_ERROR("(E117) resolved port not bound to resolved
signal",
msg.c_str());
}
diff --git a/src/systemc/ext/channel/sc_inout_rv.hh
b/src/systemc/ext/channel/sc_inout_rv.hh
index 5ff9d10..0461469 100644
--- a/src/systemc/ext/channel/sc_inout_rv.hh
+++ b/src/systemc/ext/channel/sc_inout_rv.hh
@@ -94,7 +94,7 @@
sc_inout<sc_dt::sc_lv<W> >::end_of_elaboration();
if (!dynamic_cast<sc_signal_rv<W> *>(this->get_interface())) {
std::ostringstream ss;
- ss << this->name() << " (" << this->kind() << ")";
+ ss << "port '" << this->name() << "' (" << this->kind() << ")";
SC_REPORT_ERROR(
"(E117) resolved port not bound to resolved signal",
ss.str().c_str());
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12814
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I0286fd3e3df7bc3e87f38c35086a32d8dec0bcc9
Gerrit-Change-Number: 12814
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
