Giacomo Travaglini has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/13555 )
Change subject: dev-arm: Fix Gicv2 distributor group register
......................................................................
dev-arm: Fix Gicv2 distributor group register
For each bit in GICD_IGROUPR:
value 0 means corresponding irq is group0
value 1 means corresponding irq is group 1.
Change-Id: I15699d4bc89ff3df0e0bdb41154c0d0989dc2f63
Reviewed-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/13555
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
---
M src/dev/arm/gic_v2.hh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
diff --git a/src/dev/arm/gic_v2.hh b/src/dev/arm/gic_v2.hh
index c9c1a47..4afad89 100644
--- a/src/dev/arm/gic_v2.hh
+++ b/src/dev/arm/gic_v2.hh
@@ -336,7 +336,7 @@
bool isGroup0(ContextID ctx, uint32_t int_num) {
const uint32_t group_reg = getIntGroup(ctx, intNumToWord(int_num));
- return bits(group_reg, intNumToBit(int_num));
+ return !bits(group_reg, intNumToBit(int_num));
}
/**
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13555
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I15699d4bc89ff3df0e0bdb41154c0d0989dc2f63
Gerrit-Change-Number: 13555
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
