Anthony Gutierrez has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/13755 )
Change subject: misc: Update workflow requirements in CONTRIBUTING.md
......................................................................
misc: Update workflow requirements in CONTRIBUTING.md
Change-Id: I5394ef58930fccea343414964c1fc3e18829d609
Reviewed-on: https://gem5-review.googlesource.com/c/13755
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M CONTRIBUTING.md
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Andreas Sandberg: Looks good to me, approved
Nikos Nikoleris: Looks good to me, but someone else must approve
Daniel Carvalho: Looks good to me, but someone else must approve
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 2ceded1..465d604 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -77,6 +77,19 @@
community. Additionally, the maintainer for that part of the code must
sign off
on it.
+Contributing long-lived feature branches
+----------------------------------------
+Oftentimes users or institutions add features that are necessarily complex,
+and require many changes on long-lived feature branches. In this case,
+maintaining a perfect history where all changes work individually is
infeasible.
+When contributing long-lived feature branches back to gem5's public
repository
+users may merge entire long-lived branches into a single changeset and
contribute
+their code back as long as 1) the changes have been reviewed by the
maintainer
+2) the maintainer agrees to allow such a change, and 3) the changes are
passing
+the public tests. Changes that affect common code (outside of a specific
+maintainer's purview) will still need to follow the standard gem5 protocol.
+
+
Cloning the gem5 repo to contribute
===================================
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13755
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I5394ef58930fccea343414964c1fc3e18829d609
Gerrit-Change-Number: 13755
Gerrit-PatchSet: 4
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Ali Saidi <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
