Nikos Nikoleris has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/13596 )
Change subject: configs: Revamp ruby mem test to align with MemTest
......................................................................
configs: Revamp ruby mem test to align with MemTest
The test script was broken as it was based on an older version of
MemTest, this changes revamps the creation of MemTest and removes
parameters that are not any longer valid.
Change-Id: Ib87369c1e4717c2da23e8108c72eec871e56f6ed
Signed-off-by: Nikos Nikoleris <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/13596
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M configs/example/ruby_mem_test.py
1 file changed, 3 insertions(+), 20 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
diff --git a/configs/example/ruby_mem_test.py
b/configs/example/ruby_mem_test.py
index ab658f7..68ad1ca 100644
--- a/configs/example/ruby_mem_test.py
+++ b/configs/example/ruby_mem_test.py
@@ -96,9 +96,7 @@
#
# Currently ruby does not support atomic or uncacheable accesses
#
-cpus = [ MemTest(atomic = False,
- max_loads = options.maxloads,
- issue_dmas = False,
+cpus = [ MemTest(max_loads = options.maxloads,
percent_functional = options.functional,
percent_uncacheable = 0,
progress_interval = options.progress,
@@ -106,15 +104,11 @@
for i in xrange(options.num_cpus) ]
system = System(cpu = cpus,
- funcmem = SimpleMemory(in_addr_map = False),
- funcbus = IOXBar(),
clk_domain = SrcClockDomain(clock = options.sys_clock),
mem_ranges = [AddrRange(options.mem_size)])
if options.num_dmas > 0:
- dmas = [ MemTest(atomic = False,
- max_loads = options.maxloads,
- issue_dmas = True,
+ dmas = [ MemTest(max_loads = options.maxloads,
percent_functional = 0,
percent_uncacheable = 0,
progress_interval = options.progress,
@@ -150,8 +144,7 @@
#
# Tie the cpu memtester ports to the correct system ports
#
- cpu.test = system.ruby._cpu_ports[i].slave
- cpu.functional = system.funcbus.slave
+ cpu.port = system.ruby._cpu_ports[i].slave
#
# Since the memtester is incredibly bursty, increase the deadlock
@@ -159,16 +152,6 @@
#
system.ruby._cpu_ports[i].deadlock_threshold = 5000000
-for (i, dma) in enumerate(dmas):
- #
- # Tie the dma memtester ports to the correct functional port
- # Note that the test port has already been connected to the
dma_sequencer
- #
- dma.functional = system.funcbus.slave
-
-# connect reference memory to funcbus
-system.funcbus.master = system.funcmem.port
-
# -----------------------
# run simulation
# -----------------------
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13596
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ib87369c1e4717c2da23e8108c72eec871e56f6ed
Gerrit-Change-Number: 13596
Gerrit-PatchSet: 2
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev