Hello Anouk Van Laer,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14316
to review the following change.
Change subject: arch-arm: Print register name when warning on AT
instructions
......................................................................
arch-arm: Print register name when warning on AT instructions
With this patch we don't print anymore the enum value when warning
on any AT instruction usage, but we print the sys reg name instead
Change-Id: Ic6831b98ad6b0582be69883dc9519a9d3324da30
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Anouk Van Laer <[email protected]>
---
M src/arch/arm/isa.cc
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/arch/arm/isa.cc b/src/arch/arm/isa.cc
index 5c1139d..a4ebfc1 100644
--- a/src/arch/arm/isa.cc
+++ b/src/arch/arm/isa.cc
@@ -1641,7 +1641,8 @@
// done in the same mode the core is running in. NOTE: This
// can't be an atomic translation because that causes
problems
// with unexpected atomic snoop requests.
- warn("Translating via MISCREG(%d) in functional mode! Fix
Me!\n", misc_reg);
+ warn("Translating via %s in functional mode! Fix Me!\n",
+ miscRegName[misc_reg]);
auto req = std::make_shared<Request>(
0, val, 0, flags, Request::funcMasterId,
@@ -1898,7 +1899,9 @@
// done in the same mode the core is running in. NOTE: This
// can't be an atomic translation because that causes
problems
// with unexpected atomic snoop requests.
- warn("Translating via MISCREG(%d) in functional mode! Fix
Me!\n", misc_reg);
+ warn("Translating via %s in functional mode! Fix Me!\n",
+ miscRegName[misc_reg]);
+
req->setVirt(0, val, 0, flags, Request::funcMasterId,
tc->pcState().pc());
req->setContext(tc->contextId());
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14316
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic6831b98ad6b0582be69883dc9519a9d3324da30
Gerrit-Change-Number: 14316
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Anouk Van Laer <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
