Anthony Gutierrez has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14775 )
Change subject: arch-x86: Add sys/syscall.h to x86
process.cc/syscall_emul.cc
......................................................................
arch-x86: Add sys/syscall.h to x86 process.cc/syscall_emul.cc
Change a66d12c guards the selection of getdents()
in x86's process.cc file with SYS_getdents, however
process.cc does not include the right header for
SYS_getdents, which leads to x86 choosing the
unimplemented call. This change adds sys/syscall.h to
address the problem.
This change also adds sys/syscall.hh to syscall_emu.cc,
which only includes syscall.hh and may not be supported on
all systems.
Change-Id: If1adcf41e9e455de5f2827ba98c542fdcacdc22e
Reviewed-on: https://gem5-review.googlesource.com/c/14775
Reviewed-by: Ciro Santilli <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Maintainer: Brandon Potter <[email protected]>
---
M src/arch/x86/linux/process.cc
M src/sim/syscall_emul.cc
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Nikos Nikoleris: Looks good to me, approved
Ciro Santilli: Looks good to me, approved
Brandon Potter: Looks good to me, approved
diff --git a/src/arch/x86/linux/process.cc b/src/arch/x86/linux/process.cc
index 22fe002..49d3e5a 100644
--- a/src/arch/x86/linux/process.cc
+++ b/src/arch/x86/linux/process.cc
@@ -39,6 +39,8 @@
#include "arch/x86/linux/process.hh"
+#include <sys/syscall.h>
+
#include "arch/x86/isa_traits.hh"
#include "arch/x86/linux/linux.hh"
#include "arch/x86/registers.hh"
diff --git a/src/sim/syscall_emul.cc b/src/sim/syscall_emul.cc
index 4a6fafa..3d17b5d 100644
--- a/src/sim/syscall_emul.cc
+++ b/src/sim/syscall_emul.cc
@@ -32,7 +32,7 @@
#include "sim/syscall_emul.hh"
#include <fcntl.h>
-#include <syscall.h>
+#include <sys/syscall.h>
#include <unistd.h>
#include <csignal>
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14775
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If1adcf41e9e455de5f2827ba98c542fdcacdc22e
Gerrit-Change-Number: 14775
Gerrit-PatchSet: 4
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Brandon Potter <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
