Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14918 )
Change subject: systemc: Update the ordering in the reference output for
some tests.
......................................................................
systemc: Update the ordering in the reference output for some tests.
There are a number of cases where systemc leaves the decision of what
order things happen up to the kernel, and any ordering is legal and
conformant with the spec as long as it's repeatable. The reference
outputs reflect a particular choice of ordering which is implementation
specific, and while considerable effort has been made to make the gem5
ordering match the Accellera ordering, at a certain point that's no
longer practical or desirable.
This change manually updates the reference output for the tests that
haven't been excluded for other reasons which have this sort of ordering
problem. They have been individually examined, and as best as I can
tell changing the output this way does not mask any underlying error.
One or two real problems were discovered in addition to the ordering
issues, and those were fixed in earlier changes.
Change-Id: I915269998de3f33d5ab5d1fd754a830fd620184d
Reviewed-on: https://gem5-review.googlesource.com/c/14918
Reviewed-by: Matthias Jung <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M
src/systemc/tests/systemc/1666-2011-compliance/sc_vector/golden/sc_vector.log
M
src/systemc/tests/systemc/bugs/async_reset_init/golden/async_reset_init.log
M
src/systemc/tests/systemc/communication/sc_buffer/test02/golden/sc_buffer_edge_reset.log
M src/systemc/tests/systemc/communication/sc_fifo/test04/golden/test04.log
M src/systemc/tests/systemc/communication/sc_fifo/test05/golden/test05.log
M
src/systemc/tests/systemc/communication/sc_prim_channel/test05/golden/test05.log
M
src/systemc/tests/systemc/communication/sc_prim_channel/test08/golden/test08.log
M
src/systemc/tests/systemc/communication/sc_prim_channel/test15/golden/test15.log
M
src/systemc/tests/systemc/communication/sc_prim_channel/test16/golden/test16.log
M src/systemc/tests/systemc/kernel/process_control/test06/golden/test06.log
M src/systemc/tests/systemc/kernel/process_control/test07/golden/test07.log
M src/systemc/tests/systemc/kernel/reset_signal_is/test05/golden/test05.log
M src/systemc/tests/systemc/kernel/sc_event/test14/golden/test14.log
M
src/systemc/tests/systemc/misc/communication/channel/hshake2/golden/hshake2.log
M
src/systemc/tests/systemc/misc/sim_tests/async_clock/golden/async_clock.log
M
src/systemc/tests/systemc/misc/sim_tests/manual_clock/golden/manual_clock.log
M
src/systemc/tests/systemc/misc/unit/aproc_halt/disaproc3/golden/disaproc3.log
M src/systemc/tests/systemc/misc/user_guide/async_chn/test1/golden/test1.log
M src/systemc/tests/systemc/misc/v1.0/dash0/golden/dash0.log
19 files changed, 6,745 insertions(+), 6,746 deletions(-)
Approvals:
Matthias Jung: Looks good to me, approved
Gabe Black: Looks good to me, approved
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/14918
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I915269998de3f33d5ab5d1fd754a830fd620184d
Gerrit-Change-Number: 14918
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthias Jung <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev