Hello Anouk Van Laer, Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/15278
to review the following change.
Change subject: dev-arm: Added VGIC GICV_IIDR response
......................................................................
dev-arm: Added VGIC GICV_IIDR response
Change-Id: I60e8eadbbbf07c0f8b726213fd580aeb0dd0e00b
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Reviewed-by: Anouk Van Laer <[email protected]>
---
M src/dev/arm/vgic.cc
M src/dev/arm/vgic.hh
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/dev/arm/vgic.cc b/src/dev/arm/vgic.cc
index 3e29582..adb670b 100644
--- a/src/dev/arm/vgic.cc
+++ b/src/dev/arm/vgic.cc
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013 ARM Limited
+ * Copyright (c) 2013,2018 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -47,9 +47,9 @@
#include "mem/packet_access.hh"
VGic::VGic(const Params *p)
- : PioDevice(p), platform(p->platform), gic(p->gic),
vcpuAddr(p->vcpu_addr),
- hvAddr(p->hv_addr), pioDelay(p->pio_delay),
- maintInt(p->ppint)
+ : PioDevice(p), gicvIIDR(p->gicv_iidr), platform(p->platform),
+ gic(p->gic), vcpuAddr(p->vcpu_addr), hvAddr(p->hv_addr),
+ pioDelay(p->pio_delay), maintInt(p->ppint)
{
for (int x = 0; x < VGIC_CPU_MAX; x++) {
postVIntEvent[x] = new EventFunctionWrapper(
@@ -127,6 +127,9 @@
lr->VirtualID, lr->CpuID, i, lr->EOI);
}
} break;
+ case GICV_IIDR:
+ pkt->setLE<uint32_t>(gicvIIDR);
+ break;
default:
panic("VGIC VCPU read of bad address %#x\n", daddr);
}
diff --git a/src/dev/arm/vgic.hh b/src/dev/arm/vgic.hh
index 40e42d4..872dfcf 100644
--- a/src/dev/arm/vgic.hh
+++ b/src/dev/arm/vgic.hh
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013 ARM Limited
+ * Copyright (c) 2013,2018 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -103,6 +103,7 @@
static const uint32_t LR_PENDING = 1;
static const uint32_t LR_ACTIVE = 2;
+ const uint32_t gicvIIDR;
/** Post interrupt to CPU */
void processPostVIntEvent(uint32_t cpu);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15278
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I60e8eadbbbf07c0f8b726213fd580aeb0dd0e00b
Gerrit-Change-Number: 15278
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Anouk Van Laer <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
