Has anyone had a chance to look at these patches? They look good to me, but they need maintainer approval.
They may also need to be rebased; hopefully that won't erase any approvals they have. On Mon, Dec 10, 2018 at 11:28 AM Tuan Ta <q...@cornell.edu> wrote: > Hi everyone, > > The following two patches need approvals to complete merging the commit > chain. Giacomo Gabrielli and Giacomo Travaglini showed some interests in > reviewing them. I'm not sure about the current status of their review. > > https://gem5-review.googlesource.com/c/public/gem5/+/8184 > https://gem5-review.googlesource.com/c/public/gem5/+/8188 > > I'll try to address any concern related to the two patches so that the > whole commit chain can be merged into the master branch. > > Best, > > Tuan > > On Sun, Dec 9, 2018 at 2:23 PM Alec Roelke <ar...@virginia.edu> wrote: > >> Hello Everyone, >> >> I've noticed that there are a couple of patches, starting at >> https://gem5-review.googlesource.com/c/public/gem5/+/8188/7, that have >> been sitting untouched for a while that fix a few bugs in RISC-V and appear >> to have received approvals at various points in their development. Is >> there anything keeping them from being merged, other than the fact that >> they have conflicts? I believe some of these bugs are affecting people's >> ability to simulate RISC-V. >> >> Thanks, >> Alec Roelke >> >> >> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon> >> Virus-free. >> www.avast.com >> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link> >> <#m_3059993872392915035_m_-6393324813842316912_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> >> > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
