Hello Giacomo Travaglini,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/16042
to review the following change.
Change subject: dev, arm: Removed contextId variable
......................................................................
dev, arm: Removed contextId variable
The contextId variable is only used by the debug flag and will prevent
a more optimised binary (i.e. fast) from compiling.
Change-Id: I6cefb5bc06d0d4b415df62f1278db53ba309fb87
Reviewed-by: Giacomo Travaglini <[email protected]>
---
M src/dev/arm/gic_v3.cc
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/dev/arm/gic_v3.cc b/src/dev/arm/gic_v3.cc
index 738eb11..2fb90ea 100644
--- a/src/dev/arm/gic_v3.cc
+++ b/src/dev/arm/gic_v3.cc
@@ -91,7 +91,6 @@
{
const Addr addr = pkt->getAddr();
const size_t size = pkt->getSize();
- const ContextID context_id = pkt->req->contextId();
bool is_secure_access = pkt->isSecure();
uint64_t resp = 0;
Tick delay = 0;
@@ -103,7 +102,7 @@
delay = params()->dist_pio_delay;
DPRINTF(GIC, "Gicv3::read(): (distributor) context_id %d
register %#x "
"size %d is_secure_access %d (value %#x)\n",
- context_id, daddr, size, is_secure_access, resp);
+ pkt->req->contextId(), daddr, size, is_secure_access,
resp);
} else if (redistRange.contains(addr)) {
Addr daddr = addr - redistRange.start();
uint32_t redistributor_id =
@@ -117,8 +116,8 @@
delay = params()->redist_pio_delay;
DPRINTF(GIC, "Gicv3::read(): (redistributor %d) context_id %d "
"register %#x size %d is_secure_access %d (value %#x)\n",
- redistributor_id, context_id, daddr, size,
is_secure_access,
- resp);
+ redistributor_id, pkt->req->contextId(), daddr, size,
+ is_secure_access, resp);
} else {
panic("Gicv3::read(): unknown address %#x\n", addr);
}
@@ -134,7 +133,6 @@
const size_t size = pkt->getSize();
uint64_t data = pkt->getUintX(LittleEndianByteOrder);
const Addr addr = pkt->getAddr();
- const ContextID context_id = pkt->req->contextId();
bool is_secure_access = pkt->isSecure();
Tick delay = 0;
@@ -143,7 +141,7 @@
panic_if(!distributor, "Distributor is null!");
DPRINTF(GIC, "Gicv3::write(): (distributor) context_id %d "
"register %#x size %d is_secure_access %d value %#x\n",
- context_id, daddr, size, is_secure_access, data);
+ pkt->req->contextId(), daddr, size, is_secure_access,
data);
distributor->write(daddr, data, size, is_secure_access);
delay = params()->dist_pio_delay;
} else if (redistRange.contains(addr)) {
@@ -156,8 +154,8 @@
panic_if(!redistributors[redistributor_id], "Redistributor is
null!");
DPRINTF(GIC, "Gicv3::write(): (redistributor %d) context_id %d "
"register %#x size %d is_secure_access %d value %#x\n",
- redistributor_id, context_id, daddr, size,
is_secure_access,
- data);
+ redistributor_id, pkt->req->contextId(), daddr, size,
+ is_secure_access, data);
redistributors[redistributor_id]->write(daddr, data, size,
is_secure_access);
delay = params()->redist_pio_delay;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/16042
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I6cefb5bc06d0d4b415df62f1278db53ba309fb87
Gerrit-Change-Number: 16042
Gerrit-PatchSet: 1
Gerrit-Owner: Anouk Van Laer <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
