Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/16285
Change subject: scons: Change an = to a += when accumulating sources from
filters.
......................................................................
scons: Change an = to a += when accumulating sources from filters.
The loop accidentally used a = when it should have used a +=, meaning
only the sources from the final filter would be used.
Change-Id: Ie066a5f85696f05d9ad3cf61f928b12deb39475b
---
M src/SConscript
M src/systemc/tests/SConscript
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/SConscript b/src/SConscript
index 0b66d6a..dcb08a3 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -472,7 +472,7 @@
def declare(self, env):
sources = list(self.sources)
for f in self.filters:
- sources = Source.all.apply_filter(f)
+ sources += Source.all.apply_filter(f)
objs = self.srcs_to_objs(env, sources) + env['STATIC_OBJS']
if self.main:
objs += env['MAIN_OBJS']
diff --git a/src/systemc/tests/SConscript b/src/systemc/tests/SConscript
index 2d713a0..3b0c7c3 100644
--- a/src/systemc/tests/SConscript
+++ b/src/systemc/tests/SConscript
@@ -91,7 +91,7 @@
env = env.Clone()
sources = list(self.sources)
for f in self.filters:
- sources = Source.all.apply_filter(f)
+ sources += Source.all.apply_filter(f)
objs = self.srcs_to_objs(env, sources)
objs = objs + env['MAIN_OBJS']
relpath = os.path.relpath(
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/16285
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ie066a5f85696f05d9ad3cf61f928b12deb39475b
Gerrit-Change-Number: 16285
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
