Pouya Fotouhi has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/15716 )
Change subject: mem-ruby: Fixing Topology
......................................................................
mem-ruby: Fixing Topology
The constructor assumes the number of nodes (i.e. controllers) equal to
the number of external nodes.
This is a not necessarily valid for all cases (e.g MESI_Three_Level -
where L0s are directly connected to L1s).
MachineType_base_number(MachineType_NUM) provides the total number of
controllers.
Signed-off-by: Pouya Fotouhi <[email protected]>
Change-Id: Id906099dc967ec70aa34dedb0b55351031ff242c
Reviewed-on: https://gem5-review.googlesource.com/c/15716
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/mem/ruby/network/Topology.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Nikos Nikoleris: Looks good to me, approved
diff --git a/src/mem/ruby/network/Topology.cc
b/src/mem/ruby/network/Topology.cc
index f7afffd..6da251e 100644
--- a/src/mem/ruby/network/Topology.cc
+++ b/src/mem/ruby/network/Topology.cc
@@ -51,7 +51,8 @@
Topology::Topology(uint32_t num_routers,
const vector<BasicExtLink *> &ext_links,
const vector<BasicIntLink *> &int_links)
- : m_nodes(ext_links.size()), m_number_of_switches(num_routers),
+ : m_nodes(MachineType_base_number(MachineType_NUM)),
+ m_number_of_switches(num_routers),
m_ext_link_vector(ext_links), m_int_link_vector(int_links)
{
// Total nodes/controllers in network
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15716
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Id906099dc967ec70aa34dedb0b55351031ff242c
Gerrit-Change-Number: 15716
Gerrit-PatchSet: 2
Gerrit-Owner: Pouya Fotouhi <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Pouya Fotouhi <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev