Giacomo Travaglini has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/15935 )
Change subject: configs: simpoint-profile usable with NonCachingCPUs only
......................................................................
configs: simpoint-profile usable with NonCachingCPUs only
NonCachingCPU is replacing the Atomic+fastmem option.
Change-Id: I66f5c8a880d1b3fd1331871d89e8d6a229938e57
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/15935
Reviewed-by: Daniel Carvalho <oda...@yahoo.com.br>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
---
M configs/common/CpuConfig.py
M configs/example/fs.py
M configs/example/se.py
3 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
diff --git a/configs/common/CpuConfig.py b/configs/common/CpuConfig.py
index f0d009e..1524b16 100644
--- a/configs/common/CpuConfig.py
+++ b/configs/common/CpuConfig.py
@@ -70,6 +70,7 @@
is_kvm_cpu = _cpu_subclass_tester("BaseKvmCPU")
is_atomic_cpu = _cpu_subclass_tester("AtomicSimpleCPU")
+is_noncaching_cpu = _cpu_subclass_tester("NonCachingSimpleCPU")
def get(name):
"""Get a CPU class from a user provided class name or alias."""
diff --git a/configs/example/fs.py b/configs/example/fs.py
index 05eca87..6be9ba2 100644
--- a/configs/example/fs.py
+++ b/configs/example/fs.py
@@ -189,7 +189,7 @@
# Sanity check
if options.simpoint_profile:
- if not CpuConfig.is_atomic_cpu(TestCPUClass):
+ if not CpuConfig.is_noncaching_cpu(TestCPUClass):
fatal("SimPoint generation should be done with atomic cpu")
if np > 1:
fatal("SimPoint generation not supported with more than
one CPUs")
diff --git a/configs/example/se.py b/configs/example/se.py
index 8403066..fa9e897 100644
--- a/configs/example/se.py
+++ b/configs/example/se.py
@@ -215,7 +215,7 @@
# Sanity check
if options.simpoint_profile:
- if not CpuConfig.is_atomic_cpu(CPUClass):
+ if not CpuConfig.is_noncaching_cpu(CPUClass):
fatal("SimPoint/BPProbe should be done with an atomic cpu")
if np > 1:
fatal("SimPoint generation not supported with more than one CPUs")
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/15935
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I66f5c8a880d1b3fd1331871d89e8d6a229938e57
Gerrit-Change-Number: 15935
Gerrit-PatchSet: 3
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
