Ryan Gambord has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/17071 )
Change subject: arch-arm: Fixing implicit fallthrough build errors
......................................................................
arch-arm: Fixing implicit fallthrough build errors
2c242d6 introduced implicit-fallthrough errors when building against
ARM.
Added "default: return new Unknown(machInst);" to offending switch
statements; please verify this is the corret behavior
Signed-off-by: Ryan Gambord
Change-Id: I5f5e3661ec562d4a3b2699e07d1195e6877ff959
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17071
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
---
M src/arch/arm/isa/formats/fp.isa
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
diff --git a/src/arch/arm/isa/formats/fp.isa
b/src/arch/arm/isa/formats/fp.isa
index c159dc6..cb806f6 100644
--- a/src/arch/arm/isa/formats/fp.isa
+++ b/src/arch/arm/isa/formats/fp.isa
@@ -2101,6 +2101,7 @@
} else {
return new VcvtaFpUIntD(machInst, vdInt,
vm);
}
+ default: return new Unknown(machInst);
}
case 0x1:
switch(size) {
@@ -2121,6 +2122,7 @@
} else {
return new VcvtnFpUIntD(machInst, vdInt,
vm);
}
+ default: return new Unknown(machInst);
}
case 0x2:
switch(size) {
@@ -2141,6 +2143,7 @@
} else {
return new VcvtpFpUIntD(machInst, vdInt,
vm);
}
+ default: return new Unknown(machInst);
}
case 0x3:
switch(size) {
@@ -2161,7 +2164,9 @@
} else {
return new VcvtmFpUIntD(machInst, vdInt,
vm);
}
+ default: return new Unknown(machInst);
}
+ default: return new Unknown(machInst);
}
}
} else if (b31_b24 && !b23 && b11_b9 && !op3 && b4){
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17071
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I5f5e3661ec562d4a3b2699e07d1195e6877ff959
Gerrit-Change-Number: 17071
Gerrit-PatchSet: 6
Gerrit-Owner: Ryan Gambord <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Ryan Gambord <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
